----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100814/#review1832 -----------------------------------------------------------
kparts/browserrun.cpp <http://git.reviewboard.kde.org/r/100814/#comment1506> For speed reasons, we could do the proxy-determination (which is what slaveProtocol does) only for protocols (such as FTP) where the proxy is a different protocol (such as HTTP). findProtocol in kprotocolmanager.cpp shows us how: with a if (!KProtocolInfo::proxiedBy(url.protocol()).isEmpty()) {} around the call to slaveProtocol. kparts/browserrun.cpp <http://git.reviewboard.kde.org/r/100814/#comment1504> null check should not be necessary, findByUrl never returns 0. (OK it does if no mimetypes are installed at all, but that's never supposed to happen, and isn't a supported use case anyway). - David On March 7, 2011, 5:32 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100814/ > ----------------------------------------------------------- > > (Updated March 7, 2011, 5:32 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > The attached patch fixes accessing FTP sites through HTTP proxy servers for > KDE based browsers, such as Konqueror, only. Why only browsers ? Because FTP > over HTTP proxy sends back HTML pages and not file items. As such, the > returned result cannot be shown in Dolphin or any application or dialog that > relies on the dolphin part. > > There is however a much larger issue here that this patch does not address. > How to support connections to FTP sites in all apps/dialogs that use the > dolphinpart when such requests are routed through an HTTP proxy ? There is a > possibility of using proxy tunneling like it is done for HTTPS over HTTP > proxy. However, that would require kio_ftp being changed to support > connecting to an HTTP proxy server. Not a minor change. The other option I > can think of is to modify the dolphinpart to parse the HTML file returned in > such cases and create file items out of them, but that too is not a > complicated solution. > > Anyhow, regardless of what could or could not be done to resolve that issue > in the future, I think that the dolphinpart should at least should check to > see if the ftp request is going over proxy (KProtocolManager::slaveProtocol) > and inform the user such action is not supported. > > > This addresses bug 236630. > http://bugs.kde.org/show_bug.cgi?id=236630 > > > Diffs > ----- > > kioslave/http/http.cpp 0579382 > kparts/browserrun.cpp 3a062d2 > > Diff: http://git.reviewboard.kde.org/r/100814/diff > > > Testing > ------- > > Used Konqueror to connect to FTP sites through a local proxy server. > > > Thanks, > > Dawit > >
