----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100819/ -----------------------------------------------------------
Review request for kdelibs. Summary ------- The dbus service check in KIO::SchedulerPrivate::slotReparseSlaveConfiguration always return true so long as the reparse request originats from within the application, e.g. a config dialog. That unfortunately prevents KIO::Scheduler from updating already running instances of ioslaves and as such changes won't take effect until you close the application and restart it. For example, if you change the proxy settings in Konqueror through its config dialog, those changes will not take effect until you restart Konqueror. This patch addresses this issue of config changes not taking effect immediately without breaking what seems to be the intention the problematic check mentioned above ; ensuring slotReparseSlaveConfiguration is not called twice whenever the public static function KIO::Scheduler::emitReparseSlaveConfiguration function is invoked. Diffs ----- kio/kio/scheduler.cpp d5fab85 Diff: http://git.reviewboard.kde.org/r/100819/diff Testing ------- Thanks, Dawit
