On Wednesday 16 March 2011, Thiago Macieira wrote:
>     Suggestion: 
>         path.left(path.length() - sizeof ";type=");

Unreadable.

>     sizeof(";type=") == strlen(";type=X")

A hidden off-by-one, how nice to have in our code ;)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Reply via email to