Hej, On Monday, March 21, 2011 14:16:37 Pino Toscano wrote: > Alle lunedì 21 marzo 2011, Sebastian Kügler ha scritto: > > I've just committed a branch of kdeplasma-addons containing a new > > runner plugin. It reads kdevelop sessions and makes them available > > via their name to krunner. You just pull up krunner, enter your > > session name, and start it. > > Shouldn't this be shipped aside kdevelop, instead of kdeplasma-addons? > I see various reasons for this: > a) a normal user has no use for it > b) even a developer would not have much to do with it if not installing > kdevelop (hence kdevelop could just ship it) > c) it manually parses the kdevelop session files and watches for their > changes, so if in the future kdevelop changes its storage of sessions, > this runner would break (while having it shipped with kdevelop would > allow it to be always up-to-date with it, independently from the KDE SC > version)
All valid points, I'm fine if the kdevelop developers would want to ship this runner as part of kdevelop. What do you think? > Aside from those, I've left some review in RB. I'll address those, thanks for taking the time to look at the code! -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9