----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101210/ -----------------------------------------------------------
Review request for kdelibs. Summary ------- The attached patch is the other half of the patch proposed in https://git.reviewboard.kde.org/r/101174/. It changes KPasswdServer to do the following: #1. If the extra field "skip-caching-on-query" is specified, then the queryAuthInfo* functions will not automatically store the password because the user checked the "Remember password" checkbox. This is essential for the changes made to SlaveBase::openPasswordDialog in #2. A call to addAuthInfo will now save the specified password information in the wallet. It is bit surprising that addAuthInfo seems to only update and/or store the information in memory. This again ensures that calling SlaveBase::cacheAuthentication information will actually result in the password information being saved into the wallet. Diffs ----- kpasswdserver/kpasswdserver.cpp 7330742 Diff: http://git.reviewboard.kde.org/r/101210/diff Testing ------- Thanks, Dawit
