> On May 25, 2011, 9:31 p.m., Albert Astals Cid wrote: > > kioslave/http/http.cpp, line 4334 > > <http://git.reviewboard.kde.org/r/101440/diff/1/?file=18043#file18043line4334> > > > > You are not using i18nc correctly, you need to have the parameters > > inside the call, not use arg > > Albert Astals Cid wrote: > Obviously i did not mean this line but the one above
ahh... that is correct. Just force of habit. Fixed... - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101440/#review3530 ----------------------------------------------------------- On May 25, 2011, 11:34 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101440/ > ----------------------------------------------------------- > > (Updated May 25, 2011, 11:34 p.m.) > > > Review request for kdelibs and David Faure. > > > Summary > ------- > > The attached KIO HTTP patch adds the same kind of preventative measure as > Mozilla to stop a user from being fooled into visiting a site through the > "bogus username" trick. For example, > http://www.microsoft.com%26item%3dq209354rexsddiuyjkiuylkuryt2583453453fsesfsdfsfasfdf...@www.kde.org/. > > > This addresses bug 94867. > http://bugs.kde.org/show_bug.cgi?id=94867 > > > Diffs > ----- > > kioslave/http/http.cpp b937856 > > Diff: http://git.reviewboard.kde.org/r/101440/diff > > > Testing > ------- > > Tested using the links provided in bug report a sample of which is provided > in the description area above. > > > Thanks, > > Dawit > >