----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101444/#review3545 -----------------------------------------------------------
Ship it! looks good. - Aaron J. On May 26, 2011, 10:01 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101444/ > ----------------------------------------------------------- > > (Updated May 26, 2011, 10:01 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > QTEST_KDEMAIN_WITH_COMPONENTNAME already has > QLatin1String/QString::fromLatin1 wrappers, but > QTEST_KDEMAIN_CORE_WITH_COMPONENTNAME was still missing them. > Should not do any harm to add QLatin1String wrappers in the macro, but I am > tired and might miss something, so up for review :) > > > Diffs > ----- > > kdecore/util/qtest_kde.h 29f08e5 > > Diff: http://git.reviewboard.kde.org/r/101444/diff > > > Testing > ------- > > My test programs using "QTEST_KDEMAIN_CORE( TestName )" now compile with > -DQT_NO_CAST_FROM_ASCII > > > Thanks, > > Friedrich W. H. > >
