----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101343/#review3698 -----------------------------------------------------------
OK, that's one solution. The other solution would be to fix the Undo action to actually show the text of the command to undo, like it does in many other apps ;) Looking at keditbookmarks, it seems to do that using QUndoStack::createUndoAction, which makes sure that the action text is always updated from the text of the current undo command. - David On May 12, 2011, 6:55 a.m., Alexander Potashev wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101343/ > ----------------------------------------------------------- > > (Updated May 12, 2011, 6:55 a.m.) > > > Review request for KDE Base Apps and David Faure. > > > Summary > ------- > > konq-plugins/domtreeviewer builds without there functions. > > May be these functions were left for future integration of domtreeviewer > undoable commands' into Konqueror's undo stack. But for now, they only add a > few translatable strings the user won't ever see. > > > Diffs > ----- > > konq-plugins/domtreeviewer/domtreecommands.h df8272e > konq-plugins/domtreeviewer/domtreecommands.cpp e4c7fff > > Diff: http://git.reviewboard.kde.org/r/101343/diff > > > Testing > ------- > > konq-plugins/domtreeviewer compiles after this change. > > > Thanks, > > Alexander > >
