----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101486/#review3937 -----------------------------------------------------------
This review has been submitted with commit 8edc1932ecc62370d9a31836dfa9b2bd0175a293 by Jeremy Whiting to branch KDE/4.6. - Commit On June 1, 2011, 7:29 p.m., Jeremy Paul Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101486/ > ----------------------------------------------------------- > > (Updated June 1, 2011, 7:29 p.m.) > > > Review request for kdelibs and Eike Hein. > > > Summary > ------- > > QComboBox in qt 4.8 sets currentIndex as it's USER property. Which breaks > kconfigxt saving of kcombobox values as the text inside them. I noticed this > in konversation's timestampformat setting which was getting saved as 0, or 1 > depending on the index of the combobox, rather than the text of the combobox. > > > Diffs > ----- > > kdeui/dialogs/kconfigdialogmanager.cpp 0209f49 > > Diff: http://git.reviewboard.kde.org/r/101486/diff > > > Testing > ------- > > This works here and shouldn't cause any problems even with qt 4.7 or so, just > makes QComboBox special casing come before USER property checking rather than > after. > > > Thanks, > > Jeremy Paul > >
