> On June 22, 2011, 7 p.m., David Faure wrote: > > OK. > > Sebastian Trueg wrote: > Just to be clear: does this mean: "push it now" or "push it after the > release of 4.7"?
Hmm, true, I think things are pretty frozen right now. In theory, conversion operators is something I'm wary of, they can make code ambiguous etc. But in this particular case, QList<QUrl> and QList<KUrl> are pretty incompatible otherwise, so I can't see any risk of trouble arising from this change. So I'm not objecting to it being committed -- but you retain all responsibility in case of a breakage :-) Since this is just convenience you can work around, I guess it's safer to just push to master (4.7 is already branched). - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101702/#review4073 ----------------------------------------------------------- On June 20, 2011, 11:58 a.m., Sebastian Trueg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101702/ > ----------------------------------------------------------- > > (Updated June 20, 2011, 11:58 a.m.) > > > Review request for kdelibs. > > > Summary > ------- > > Internally in Nepomuk we use QUrl instead of KUrl since Soprano uses QUrl and > we do not need the additional power of KUrl most of the time. Thus, > conversion between KUrl and QUrl is important. This patch adds a constructor > to KUrl::List which allows to use a QList<QUrl> as basis and an operator > which provides automatic conversion from KUrl::List to QList<QUrl>. > > > Diffs > ----- > > kdecore/io/kurl.h 52af985 > kdecore/io/kurl.cpp 90ececf > > Diff: http://git.reviewboard.kde.org/r/101702/diff > > > Testing > ------- > > > Thanks, > > Sebastian > >
