----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101530/#review4243 -----------------------------------------------------------
This review has been submitted with commit 4cee79c5e24bb40ad024ba520f4fce93ad7848d0 by Simon Persson to branch master. - Commit On June 7, 2011, 7:21 a.m., Simon Persson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101530/ > ----------------------------------------------------------- > > (Updated June 7, 2011, 7:21 a.m.) > > > Review request for kdelibs and Michael Jansen. > > > Summary > ------- > > Make this beautiful piece of code even more beautiful! The proper fix would > be to add platform-specific functions to check if shift changes the symbol > produced when the key is pressed, but that will have to wait. > > > This addresses bug 184195. > http://bugs.kde.org/show_bug.cgi?id=184195 > > > Diffs > ----- > > kdeui/widgets/kkeysequencewidget.cpp a35c2b4 > > Diff: http://git.reviewboard.kde.org/r/101530/diff > > > Testing > ------- > > Not tested. > > > Thanks, > > Simon > >
