On Wednesday 29 June 2011 23:13:14 Simon Persson wrote: > On Tuesday 07 June 2011 16.10.55 Aaron J. Seigo wrote: > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/101515/#review3736 > > ----------------------------------------------------------- > > > > > > both of the classes that need this are in the kdeui library, so there is > > no > > reason to export this symbol. it is not imho API that needs to or should > > be public. i'd instead recommend moving this to a private header, such as > > kglobalaccel_p.h and including that header in both of the .cpp classes > > that need it. > > > > - Aaron J. > > Aaron, > > I forgot that there's a kglobalaccel in kdelibs when I wrote the summary.. > therefore I didn't specify that this function is needed by the daemon > kglobalaccel from kde-runtime. > > I went ahead and commited today, in retrospect I should probably have > written this email first... > Let me know if you still have concerns regarding this!
We could move the code to KKeyServer . It does not feel complete right to be there but better than the widget. Mike