----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101923/#review4618 -----------------------------------------------------------
Ship it! Thanks for the patch! It looks good, but it only makes sense to push it to the 4.7 branch: For master Dolphin 2.0 will be integrated until beginning of August which has a new view-engine that makes this patch obsolete. If you plan to do further fixes for the icons-, details- or column-view (or related classes) please contact me directly before as most probably the patches are not compatible with the new view-engine. - Peter On July 11, 2011, 9:25 p.m., Marcel Partap wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101923/ > ----------------------------------------------------------- > > (Updated July 11, 2011, 9:25 p.m.) > > > Review request for KDE Base Apps, David Faure and Peter Penz. > > > Summary > ------- > > The auto-calculated width of columns always is same regardless of custom font > style so there was sure something wrong.. > => Setting the font in the viewOptions() actually has no effect on either > viewport or view, has to be done via setFont(). So > - adding setFont(m_font) in view init phase > - removing font stuff from viewOptions() and NOOP assignment in > slotGlobalSettingsChanged() > - avoiding extra inter-object calls by using m_font directly > Also replaced abusing fontMetrics.height for horizontalGap - by coincidence > it was more then needed, but for bigger fonts might be 20px and up while > usually only 10px is needed. Pixel-perfect calculation required DEEEEEEP > tracing throughout QT style rendering stuff - (PM_FocusFrameHMargin+1)*2 > seems to be the way it is calculated, +const 4 which is hard-coded all over > the place though. > > > Diffs > ----- > > dolphin/src/views/dolphindetailsview.cpp 0ce26df > > Diff: http://git.reviewboard.kde.org/r/101923/diff > > > Testing > ------- > > cgdb tracing aaall day long ^^ > > > Thanks, > > Marcel > >