----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101931/#review5352 -----------------------------------------------------------
This review has been submitted with commit 370d3ed6e5153fc61b774cf2640acc72d334033d by Burkhard Lück to branch master. - Commit On July 12, 2011, 4:01 p.m., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101931/ > ----------------------------------------------------------- > > (Updated July 12, 2011, 4:01 p.m.) > > > Review request for kdelibs and Darío Andrés Rodríguez. > > > Summary > ------- > > Quoting the BR: > "When using KMessageBox::detailedError() it sometimes doesn't resize properly > to > show all the text" > See kgpg error dialog without kdelibs patch. The text "your keyringxx" is cut > off. > > Pressing Details button (kgpg error dialog without kdelibs patch after > clicking details) > resizes the dialog properly and all text is visible. > > Last screenshot (kgpg error dialog with kdelibs patch) shows the dialog after > the start > and before clicking the Deatils button, everything is properly readable. > > I commit this review request on behalf of Dario Andres > (https://bugs.kde.org/show_bug.cgi?id=193097#c9) > > > This addresses bug 193097. > http://bugs.kde.org/show_bug.cgi?id=193097 > > > Diffs > ----- > > kdeui/dialogs/kdialog.cpp 32f5df0 > > Diff: http://git.reviewboard.kde.org/r/101931/diff > > > Testing > ------- > > Tested with kgpg error dialog, see third screenshot. > > > Screenshots > ----------- > > kgpg error dialog without kdelibs patch > http://git.reviewboard.kde.org/r/101931/s/200/ > kgpg error dialog without kdelibs patch after clicking details > http://git.reviewboard.kde.org/r/101931/s/201/ > kgpg error dialog with kdelibs patch > http://git.reviewboard.kde.org/r/101931/s/203/ > > > Thanks, > > Burkhard > >