----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102098/#review5460 -----------------------------------------------------------
This review has been submitted with commit a383ac8c7d3f666018e31d152fbe97b34260e840 by Frank Reininghaus to branch KDE/4.7. - Commit On July 27, 2011, 4:31 p.m., Frank Reininghaus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102098/ > ----------------------------------------------------------- > > (Updated July 27, 2011, 4:31 p.m.) > > > Review request for kdelibs, Aurélien Gâteau and David Faure. > > > Summary > ------- > > Since commit b064749a754ec358170ecb7f19828e4216f6e965, KDE palette and font > settings are only used when running KDE apps in a full KDE session. This > makes KGlobalSettingsTest fail if the test is not run in a full KDE session, > see > > http://my.cdash.org/testSummary.php?project=16&name=kdeui-kglobalsettingstest&date=2011-07-27 > > This commit changes KGlobalSettings' unit test to reflect that change. My > first idea was to change the unit test such that it verifies the expected > behaviour for both situations, i.e., apps run in a full KDE session and apps > run in some other kind of session, but I could not figure out a way to do > this without changing the KDE_FULL_SESSION environment variable before the > unit test executable is run. > > In the case that the signal is not expected, I reduced the kWaitForSignal > timeout to prevent wasting too much time each time the test is run. > > > Diffs > ----- > > kdeui/tests/kglobalsettingstest.h 69ed5bf > kdeui/tests/kglobalsettingstest.cpp 464825d > > Diff: http://git.reviewboard.kde.org/r/102098/diff > > > Testing > ------- > > The test passes here (run by my kde-devel user in a Konsole inside the > regular user's KDE 4.6 session). > > > Thanks, > > Frank > >
