> On Aug. 7, 2011, 7:59 a.m., Thiago Macieira wrote: > > Looks good, but I have a question on the cache: what are its features? > > > > Is it permanent (saved to disk)? Is it shared among applications? Not > > shared among ioslaves through one application, I really mean across > > applications? > > > > If the answer is "no" on both accounts, I recommend getting rid of it too, > > since QHostInfo already has a cache.
>From what i can read in the code, the answer is "no" and "no" but it seems the >cache provides some other features like a ttl setting and whatnot so we still >need it if we want to keep those. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/#review5472 ----------------------------------------------------------- On Aug. 7, 2011, 4:07 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102238/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2011, 4:07 a.m.) > > > Review request for kdelibs. > > > Summary > ------- > > This patch replaces the creation of a new thread for every DNS lookup with a > local even loop based solution. This change addresses the issue of crashes > that can arise from terminating the thread when the desired timeout duration > is exceeded. See http://git.reviewboard.kde.org/r/102179/. > > > Diffs > ----- > > kio/kio/hostinfo.cpp fcb7889 > > Diff: http://git.reviewboard.kde.org/r/102238/diff > > > Testing > ------- > > > Thanks, > > Dawit > >
