----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102262/#review5621 -----------------------------------------------------------
Ship it! Ah, I see. Indeed after reading QAction::iconText() it's all clear ;) But yeah this is quite obviously a bug in qaction (qt_strippedText), which should remove "..." only at the end. - David On Aug. 9, 2011, 3:32 p.m., Yoann Laissus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102262/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2011, 3:32 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > When a bookmark name, is too long, its name is truncated with "..." at the > middle. > But, QAction strip those three dots by default. > This patch solves this issue by defining imageText. > > > Diffs > ----- > > kio/bookmarks/kbookmarkmenu.cc 873f4a8 > > Diff: http://git.reviewboard.kde.org/r/102262/diff > > > Testing > ------- > > It works with Konqueror and rekonq. > > > Thanks, > > Yoann > >