----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102439/#review6012 -----------------------------------------------------------
Ship it! Looks good, go for it. - Jeremy Paul On Aug. 25, 2011, 9:02 p.m., Volker Krause wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102439/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2011, 9:02 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > So far knewstuff has "gpg" hardcoded as the executable name for GnuPG. This > patch also allows the use of "gpg2" instead, if the "gpg" executable is not > present (both are compatible as far as we are concerned here). Since kdepim* > requires GnuPG2, you are most likely using gpg2 already anyway, via backward > compatibility forwards. On MeeGo however this is not available and packages > for GnuPG1 and 2 are not installable at the same time. > > > Diffs > ----- > > knewstuff/knewstuff3/core/security.cpp 5654787 > > Diff: http://git.reviewboard.kde.org/r/102439/diff > > > Testing > ------- > > > Thanks, > > Volker > >
