> On Aug. 27, 2011, 9:31 a.m., Peter Penz wrote: > > Thanks for the update, but could you please revert the changes with > > KGlobalSettings::changeCursorOverIcon()? I consider this option an > > unnecessary "micro-option" and plan to implement the same behavior as in > > Dolphin 1.7. > > Tirtha Chatterjee wrote: > Yeah sure. But TBH, it does feel a bit odd if a pointing hand cursor does > not appear, and the folder opens on a single click. Reverting it, and > committing for now.
Thanks for pushing this! > But TBH, it does feel a bit odd if a pointing hand cursor does not appear, > and the folder opens on a single click We'll introduce the pointing hand cursor later, but: - not as an option - and first the selection markers need to be reintroduced again, as this will make the code for the "pointing hand" a little bit more complicated - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102447/#review6050 ----------------------------------------------------------- On Aug. 27, 2011, 7:31 a.m., Tirtha Chatterjee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102447/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2011, 7:31 a.m.) > > > Review request for KDE Base Apps and Peter Penz. > > > Summary > ------- > > Honours the KGlobalSettings::singleClick() setting (set from Mouse KCM, > whether files should be opened on single or double clicks), and functions > accordingly. > > > Diffs > ----- > > dolphin/src/kitemviews/kitemlistcontroller.cpp 29e2f47 > > Diff: http://git.reviewboard.kde.org/r/102447/diff > > > Testing > ------- > > Yes tested and works. > > > Thanks, > > Tirtha > >