> On Aug. 29, 2011, 9:40 a.m., Peter Penz wrote: > > Thanks for the update! Looks good and is exactly like the proposal you, > > Frank and I discussed per e-mail. As usual I've added a punch of my > > nitpicking stuff ;-) Please push it to master after fixing, you don't need > > to add another diff here.
I have used itemActivated signal here since itemTriggered is already used by DolphinView. Then I noticed that in my previous keyboard-searching patch, we use the name 'activation' to mean selection. So is it okay to use activation here? - Tirtha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102450/#review6128 ----------------------------------------------------------- On Aug. 29, 2011, 9:14 a.m., Tirtha Chatterjee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102450/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2011, 9:14 a.m.) > > > Review request for KDE Base Apps and Peter Penz. > > > Summary > ------- > > Allow opening files and directories by pressing 'Enter' key. In case multiple > files are selected when enter is pressed, all of them are opened. In case of > multiple directories, the first directory gets opened in the current tab, > while the other directories open in new tabs. > > > Diffs > ----- > > dolphin/src/kitemviews/kitemlistcontroller.h 04d4985 > dolphin/src/kitemviews/kitemlistcontroller.cpp 207535c > dolphin/src/views/dolphinview.h 437f12f > dolphin/src/views/dolphinview.cpp 959e4da > > Diff: http://git.reviewboard.kde.org/r/102450/diff > > > Testing > ------- > > Yes, tested and working. > > > Thanks, > > Tirtha > >
