> On Oct. 8, 2011, 10:48 p.m., Gary L. Greene Jr wrote:
> > As someone that works with NFS home directory systems with autofs much of
> > the time, I find the use of an icon in the users home directory (especially
> > on default configurations that tend to display many users on KDM) a very
> > bad idea. Please, lets move these to /var/tmp/kdecache-$USERNAME instead.
>
> Christoph Feck wrote:
> A cache is temporary, it could be deleted any time. Configuration files
> certainly should not be stored there.
That's easy, just configure KDM to use "system" images only... they will be
stored in /usr/share/kde4/apps/kdm/faces per default, and IMHO that location is
configurable.
This patch is about the KCM dialogue for individual users ("User account &
password"), which is totally unrelated to KDM. KDM behaviour is not changed by
this patch.
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102799/#review7185
-----------------------------------------------------------
On Oct. 7, 2011, 11:46 a.m., Ralf Jung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102799/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2011, 11:46 a.m.)
>
>
> Review request for KDE Base Apps.
>
>
> Description
> -------
>
> Currently, the "User account & password" KCM refuses to change the user image
> if KDM is set up not to use user images. That however does not make much
> sense, all this applet does is writing the image to ~/.face.icon, which the
> user can do manually anyway. The fact that KDM might or might not actually
> display this image in the user selection is unrelated, as KDM is not even the
> only user of this file: Plasma Kickoff displays it, and maybe more apps use
> it (GDM uses a different file, though)
>
> This patch therefore removes the check for the KDM settings and makes the KCM
> simply manage the .face.icon file. It does not fall back to the system
> default if the user image does not exist, as Plasma Kickoff does not do that
> either. The patch also adds a button in the "Change face" dialogue to remove
> the user image, to make it possible to go back to the default state again.
>
> After changing the image, the user still has to log off and on again for
> Plasma to use it - Plasma would have to somehow listen to changes to that
> file. I don't know if that is desired.
>
>
> This addresses bug 183245.
> http://bugs.kde.org/show_bug.cgi?id=183245
>
>
> Diffs
> -----
>
> kdepasswd/kcm/chfacedlg.h c389e49
> kdepasswd/kcm/chfacedlg.cpp a80c5af
> kdepasswd/kcm/main.h 320126f
> kdepasswd/kcm/main.cpp 5ce1961
>
> Diff: http://git.reviewboard.kde.org/r/102799/diff/diff
>
>
> Testing
> -------
>
> Compiled and verified that the KCM now behaves as desired.
>
>
> Thanks,
>
> Ralf Jung
>
>
