----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103109/#review8124 -----------------------------------------------------------
Ship it! Ship It! - Andreas Schneider On Nov. 10, 2011, 10:39 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103109/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2011, 10:39 p.m.) > > > Review request for KDE Runtime and Andreas Schneider. > > > Description > ------- > > The attached patch: > > - Implements SlaveBase::copy so that copying to and from the local filesystem > is optimized. This makes the common use case of uploading and downloading to > and from the local file system much much faster. > - Sends the correct mime-type information when download a file from remote > server. > > > Diffs > ----- > > kioslave/sftp/kio_sftp.h c937e2e > kioslave/sftp/kio_sftp.cpp adc918a > kioslave/sftp/sftp.protocol 696647d > > Diff: http://git.reviewboard.kde.org/r/103109/diff/diff > > > Testing > ------- > > - Upload a large file from local file system to sftp server, cancel while > still in progress and redo the upload. > - Download a large file from sftp server to file system, cancel while still > in progress and redo the download. > - Repeat steps #1 and #2 with a list of files instead of just one large file. > - Repeat the above steps after disabling "Mark partially uploaded files". > > > Thanks, > > Dawit Alemayehu > >
