> On Nov. 9, 2011, 8:50 p.m., Christoph Feck wrote: > > It's already fixed, at least in master. The patch is wrong, too, because > > that signal doesn't exists in QSpinBox. Looks like you did not test it :) > > Christoph Feck wrote: > Sorry, I failed reading, forget what I wrote. > > Still, I suggest to use 'valueChanged' signal, otherwise simply clicking > and leaving the spinbox will flag a change. > > Florian Eßer wrote: > The signal comes from QAbstractSpinBox. > As I wrote in http://bugs.kde.org/show_bug.cgi?id=264070 , the problem > with valueChanged is that just opening the screen settings will flag a > change, which is even worse than clicking and leaving. I guess valueChanged() > gets triggered when the spin boxes are initialized to their default values. > > Thomas Lübking wrote: > w/o having looked at the expanded code, this applies to all value > changes, so they should all be connected _after_ the initial values have been > loaded. > > (to be more annoying: "setConfigDirty" should actually compare the > present configuration with the demanded configuration and update the UI > respectively)
I already submitted a patch fixing this here: https://git.reviewboard.kde.org/r/102631/ Don't know if it's been applied yet, I don't have push access... - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103093/#review8062 ----------------------------------------------------------- On Nov. 9, 2011, 4:50 p.m., Florian Eßer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103093/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2011, 4:50 p.m.) > > > Review request for KDE Base Apps, Solid and Alex Fiestas. > > > Description > ------- > > Adds the missing connections for absolutePosX and absolutePosY. > > > This addresses bug 264070. > http://bugs.kde.org/show_bug.cgi?id=264070 > > > Diffs > ----- > > kcontrol/randr/outputconfig.cpp 9595811 > > Diff: http://git.reviewboard.kde.org/r/103093/diff/diff > > > Testing > ------- > > compiled it locally, replaced my Kubuntu's /usr/lib/kde4/kcm_randr.so with > the self-compiled one --> works! > > > Thanks, > > Florian Eßer > >