-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103226/
-----------------------------------------------------------
(Updated Nov. 24, 2011, 7:37 a.m.)
Review request for kdelibs and David Faure.
Description
-------
The attached patch fixes the scenario outlined in bug# 179663 by making the
best effort to identify and use the top most window when invoking KIO
functions. That way any password information supplied by the user is cached,
even if the user did not check the "Remember password" checkbox, for the
duration of the application instead of just the lifetime of the file dialog.
Right now almost all KFileDialog's KIO access does not set the widget
parameter. If a site then requires authentication, no window-id information
will be passed to it. That in turn results in the user supplied password being
cached for only a very very short duration, ~10 secs. Afterwards, the password
is removed and the user is inevitably re-prompted to supply the same
credentials again.
This addresses bug 179663.
http://bugs.kde.org/show_bug.cgi?id=179663
Diffs (updated)
-----
kfile/kdiroperator.cpp 4c93ac9
kfile/kdirselectdialog.cpp 0212e58
kfile/kfilewidget.cpp 09b86d4
kfile/knewfilemenu.cpp ac54041
Diff: http://git.reviewboard.kde.org/r/103226/diff/diff
Testing
-------
Tested with the scenario outlined in the afforementioned bug report using a
publicly available demo webdav server, webdav://demo.sabredav.org.
Thanks,
Dawit Alemayehu
