----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103245/ -----------------------------------------------------------
Review request for KDE Runtime. Description ------- KPasswdServer currently processes requests to prompt the user for passwords serially, i.e. one request at a time even if those requests came two totally different applications. Unfortunately that results one application waiting on a completely unrelated application to receive authorization information, which IMHO is unacceptable. The commit that caused this problem was a4cc5583 and its intent was to address the issue 2 or more password dialogs being shown at the same time. The attached patch modifies that commit so that processRequest will handle requests so long as #1. The request comes from two separate window ids. #2. There is no pending prompt for the requested key (read: host+port). So long as the above two conditions are met, the password prompt will be shown as required. This fixes a bug report, which I cannot find at the moment, where attempting to log into an sftp server in one Konqueror instance prevented the user from logging into a router admin interface in a completely different Konqueror instance. Diffs ----- kpasswdserver/kpasswdserver.h 351cb7c kpasswdserver/kpasswdserver.cpp cc8ded2 Diff: http://git.reviewboard.kde.org/r/103245/diff/diff Testing ------- Attempt to log into two different sites from two different applications of two different instances of the same application. Thanks, Dawit Alemayehu
