----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/#review8691 -----------------------------------------------------------
You should add "ereslibre" in people. - Alex Fiestas On Dec. 3, 2011, 10:55 a.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103313/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2011, 10:55 a.m.) > > > Review request for kdelibs. > > > Description > ------- > > Basically, what I do is: > If there are one or zero columns, hide the horizontalScrollBar until it is > needed. (it has worked in the past, but in another file). > Apply the same strategy with files. > > Additional stuff: > Moved the common calculus of itemSize outside of the if then else. > > > This addresses bugs 213068 and 287847. > http://bugs.kde.org/show_bug.cgi?id=213068 > http://bugs.kde.org/show_bug.cgi?id=287847 > > > Diffs > ----- > > kdeui/itemviews/kcategorizedview.cpp 46a1cde > kutils/kpluginselector.cpp ca0691d > > Diff: http://git.reviewboard.kde.org/r/103313/diff/diff > > > Testing > ------- > > Krunner config does not loop (neither kgetnewstuff from kstars). I can not > test with amarok (I've hit by an amarok start bug). > Please, test with other programs. > > > Thanks, > > Jaime Torres Amate > >