> On Dec. 18, 2011, 9:02 a.m., David Faure wrote:
> > How does one simply enable/disable individual areas? Using the comboboxes? 
> > I think the fast-mode-checkbox should stay, in the list widget. Other than 
> > that, it looks good.

What do you mean with "fast-mode-checkbox"? If you are referring to the dialog 
which appears when KDebugDialog is started without the --fullmode option, it is 
still there. I only changed the fullmode dialog. If I find the motivation I may 
look into merging them as Eike suggested, but keeping the ability to disable 
all output of an area with a single-click as it is much faster than adjusting 4 
combo boxes.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103403/#review9032
-----------------------------------------------------------


On Dec. 13, 2011, 1:15 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103403/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2011, 1:15 p.m.)
> 
> 
> Review request for KDE Runtime and David Faure.
> 
> 
> Description
> -------
> 
> This patch replaces the area combobox in kdebugdialog --fullmode with a 
> searchable tree widget.
> 
> The patch is quite large because I fixed the indentation first and converted 
> the dialog to Designer.
> Individual commits are available in agateau/kdebugdialog-ui branch of the 
> kde-runtime repo.
> 
> 
> Diffs
> -----
> 
>   kdebugdialog/CMakeLists.txt ed66db6 
>   kdebugdialog/kabstractdebugdialog.h 254109e 
>   kdebugdialog/kabstractdebugdialog.cpp 68d98e8 
>   kdebugdialog/kdebugdialog.h a186cfa 
>   kdebugdialog/kdebugdialog.cpp 4d01256 
>   kdebugdialog/kdebugdialog.ui PRE-CREATION 
>   kdebugdialog/klistdebugdialog.h af3ec4d 
>   kdebugdialog/klistdebugdialog.cpp 4608e7b 
>   kdebugdialog/main.cpp 13ad8dc 
> 
> Diff: http://git.reviewboard.kde.org/r/103403/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Before
>   http://git.reviewboard.kde.org/r/103403/s/369/
> After
>   http://git.reviewboard.kde.org/r/103403/s/370/
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

Reply via email to