> On Jan. 2, 2012, 11:05 a.m., David Faure wrote: > > I don't like it very much (the whole find file stuff and its handling of > > relative paths is messy - I blame myself), but I can't think of a better > > way for now, nor of a case where we wouldn't want this. > > > > Maybe split it in two lines though, one line calling .name() -- with the > > comment why, and one line extracting fileName(), with a reference to the > > bug report. > > > > I trust that you also tested it in the standard case, where name() contains > > no slash.
Ok. I will split the line into two and document why it is being done that way. And yes I have tested to make sure there is no regression in the standard case. - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103594/#review9435 ----------------------------------------------------------- On Dec. 31, 2011, 5:23 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103594/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2011, 5:23 a.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > The attached patch fixes the issue where searching for a file name in Find > File dialog, and attempting to rename it using the properties dialog shows > the relative path of to the file instead of just the filename. > > > This addresses bug 160964. > http://bugs.kde.org/show_bug.cgi?id=160964 > > > Diffs > ----- > > kio/kfile/kpropertiesdialog.cpp d05cf14 > > Diff: http://git.reviewboard.kde.org/r/103594/diff/diff > > > Testing > ------- > > * Open Konqueror > * Go to your home directory. > * Launch the find file dialog and search for a file that resides inside one > of those folder in your home directory. > * Right click on the file listed and select Properties. > * Check the name of the file displayed before and after the patch. > * To verify the patch works, change the name of the file. > > > Thanks, > > Dawit Alemayehu > >
