----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103617/#review9499 -----------------------------------------------------------
kparts/browseropenorsavequestion.cpp <http://git.reviewboard.kde.org/r/103617/#comment7787> am I misreading this, or will mime->comment() be called if !mime ? and hence result in a crash? - Milian Wolff On Jan. 3, 2012, 2:34 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103617/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2012, 2:34 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > * Factored out the code that is used to determine the actual mime-type from > either another mime-type or a filename. > * Display the mime comment instead of the raw type in setSuggestedFileName as > it is done in the constructor. > > > Diffs > ----- > > kparts/browseropenorsavequestion.cpp 092198f > > Diff: http://git.reviewboard.kde.org/r/103617/diff/diff > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
