----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103882/#review10585 -----------------------------------------------------------
Ship it! OK I understand. This should actually replace m_remoteProtocolPlugins then, which indeed is missing crucial information. But no reason to keep both. I understand if you don't want to do this, in that case just commit and I'll clean up ;) - David Faure On Feb. 8, 2012, 9:56 p.m., Sebastian Trueg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103882/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2012, 9:56 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > The problem is fairly simple: I needed to create previews for directory items > in a custom KIO slave. Writing the ThumbCreator was simple. But it got never > called. The reason is that the thumbnail kio slave always uses its own > directory thumbnailing method for folders if the plugin name is not specified > in the metadata. The PreviewJob on the other hand does only specify the > "plugin" metadata field for "local" ThumbCreators; remote ThumbCreators are > only checked for existance. > This patch fixes that by first checking for a specialized ThumbCreator plugin > by protocol and then falling back to the old way of detection my mime-type. > > > Diffs > ----- > > kio/kio/previewjob.cpp 5635875 > > Diff: http://git.reviewboard.kde.org/r/103882/diff/ > > > Testing > ------- > > Tested on my custom KIO slave: perfect thumbnails. Thumbnails for everything > else still working fine. > > > Thanks, > > Sebastian Trueg > >
