----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104084/#review11006 -----------------------------------------------------------
Ship it! Yes, 4.8. - David Faure On Feb. 26, 2012, 5:53 p.m., Martin Koller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104084/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2012, 5:53 p.m.) > > > Review request for kdelibs and David Faure. > > > Description > ------- > > remove KDE_NO_DEPRECATED from KPushButton::setIcon( const QIcon &pix ); since > QIcon can already load icons from the theme. > > The diff is against KDE/4.8 - to which branch shall I commit ? > > > Diffs > ----- > > kdeui/widgets/kpushbutton.h 279ac5e > kdeui/widgets/kpushbutton.cpp 6e45631 > > Diff: http://git.reviewboard.kde.org/r/104084/diff/ > > > Testing > ------- > > compiled kdelibs > > > Thanks, > > Martin Koller > >