> On Feb. 13, 2012, 11:26 a.m., David Faure wrote: > > kioslave/recentdocuments/recentdocuments.cpp, line 58 > > <http://git.reviewboard.kde.org/r/103849/diff/3/?file=48801#file48801line58> > > > > Why use KUrl here? This is always a local path, and you turn it into a > > local path in order to use it. > > It would be much simpler to just use a QString here, concatenate > > directory and filename, then use KDesktopFile with that.
Well.. any further comment on this review? :) - Xuetian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103849/#review10588 ----------------------------------------------------------- On Feb. 15, 2012, 3:11 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103849/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2012, 3:11 p.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > Add recentdocuments:/ kio slave to kde-runtime. > Did some little rename "recentdocument -> recentdocuments", based on > http://kde-apps.org/content/show.php?content=145878 > > > Diffs > ----- > > kioslave/CMakeLists.txt f3d5b00 > kioslave/recentdocuments/CMakeLists.txt PRE-CREATION > kioslave/recentdocuments/Messages.sh PRE-CREATION > kioslave/recentdocuments/recentdocuments.h PRE-CREATION > kioslave/recentdocuments/recentdocuments.cpp PRE-CREATION > kioslave/recentdocuments/recentdocuments.protocol PRE-CREATION > kioslave/recentdocuments/recentdocumentsnotifier.h PRE-CREATION > kioslave/recentdocuments/recentdocumentsnotifier.cpp PRE-CREATION > kioslave/recentdocuments/recentdocumentsnotifier.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103849/diff/ > > > Testing > ------- > > Works for me. > > > Thanks, > > Xuetian Weng > >
