----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12071 -----------------------------------------------------------
service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop <http://git.reviewboard.kde.org/r/104428/#comment9508> You are the author of this plugin, right? You should write your name here and your e-mail below. service/plugins/globalshortcuts/globalshortcuts.h <http://git.reviewboard.kde.org/r/104428/#comment9509> Is this copyright line correct? Who is Nick Shaforostoff? Is him aware you are submitting a patch using his name? In the globalshortcuts.cpp the copyright line states Ivan Cukic as copyright holder. Who is the correct copyright holder? service/plugins/globalshortcuts/globalshortcuts.h <http://git.reviewboard.kde.org/r/104428/#comment9511> guards are always upper case. service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9510> Please move this lines to before "#include <KDebug>" line. service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9512> In my old review I asked to do not use QDBusReply or waitForFinished, they can cause freezes in the whole Plasma Desktop. service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9515> In my old review I wrote that you can replace this line and the next two lines with only one call. Read my old review to see how to do that. service/plugins/globalshortcuts/globalshortcuts.cpp <http://git.reviewboard.kde.org/r/104428/#comment9513> In my old review I asked to normalize this connect statement. Read my old review to know how to do that. - Lamarque Vieira Souza On March 31, 2012, 6:15 p.m., makis marimpis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104428/ > ----------------------------------------------------------- > > (Updated March 31, 2012, 6:15 p.m.) > > > Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić. > > > Description > ------- > > (follows discarded review: 104391) > > The plugin adds global keyboard shortcuts for changing the activity. > Defaults start from Qt::MetaModifier + Qt::Key_F1. > > Initially, this functionality was implemented (without correct results) using > KActitivities::Controller. > Using DBus seems fine, just that... it forces kamd to start with 3-4 seconds > delay - so it really needs modification/and i would like more guidance > related to dbus :D. > Other than that, feedback is needed. > > > This addresses bugs 265069 and 273467. > http://bugs.kde.org/show_bug.cgi?id=265069 > http://bugs.kde.org/show_bug.cgi?id=273467 > > > Diffs > ----- > > service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 > service/plugins/globalshortcuts/CMakeLists.txt PRE-CREATION > > service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop > PRE-CREATION > service/plugins/globalshortcuts/globalshortcuts.h PRE-CREATION > service/plugins/globalshortcuts/globalshortcuts.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/104428/diff/ > > > Testing > ------- > > Logged in. > Used the default shortcuts to switch activities. > It works! > > > Thanks, > > makis marimpis > >