----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104479/#review12163 -----------------------------------------------------------
In kdelibs coding style, we use spaces around binary operators (see surrounding code). x=y; => x = y; x+3 => x + 3 etc. - Christoph Feck On April 4, 2012, 5:10 a.m., Anant Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104479/ > ----------------------------------------------------------- > > (Updated April 4, 2012, 5:10 a.m.) > > > Review request for kdelibs and Sebastian Trueg. > > > Description > ------- > > Patch for bug 171343 (Improving star rating in dolphin) > As suggested here : https://bugs.kde.org/show_bug.cgi?id=171343#c4 > > Now: Clicking once on an empty star= 1 star > Clicking again = 1/2 star > Clicking again = Clears the selected star > > > Diffs > ----- > > kdeui/widgets/kratingwidget.cpp 811ca0a > > Diff: http://git.reviewboard.kde.org/r/104479/diff/ > > > Testing > ------- > > Tested in dolphin > > > Thanks, > > Anant Kamath > >