> On April 26, 2012, 5:09 p.m., Albert Astals Cid wrote: > > If i understand you correctly you are suggesting to create a bug (option > > that does nothing)? > > > > Doesn't make much sense.
Huh ? I do not follow. By "option that does nothing" you mean this change by itself does nothing that is correct. But that is true of every option in that dialog as well. Moreover, it is a well known fact that you cannot post a patch for different components in reviewboard. Anyhow, the option will most definitely be used by kwebkitpart. Whether or not some body implements support for it in khtml is a question I cannot answer. That is what I meant. - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104631/#review12934 ----------------------------------------------------------- On April 26, 2012, 3:48 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104631/ > ----------------------------------------------------------- > > (Updated April 26, 2012, 3:48 a.m.) > > > Review request for KDE Base Apps, kdelibs and David Faure. > > > Description > ------- > > A patch to make that provides an option to disable the "offer to save website > passwords". Note that for this patch to take effect this option will have to > be used at at the browser engine level. Those patches are separate to this > one. This is just the GUI configuration. > > > Diffs > ----- > > konqueror/settings/konqhtml/htmlopts.h 69f36d8 > konqueror/settings/konqhtml/htmlopts.cpp e5d6deb > > Diff: http://git.reviewboard.kde.org/r/104631/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > Option for disabling KWallet integration > http://git.reviewboard.kde.org/r/104631/s/544/ > > > Thanks, > > Dawit Alemayehu > >
