> On May 29, 2011, 1:05 p.m., Thomas Lübking wrote: > > Not sure wheher it's really worth it (though using ARGB over XShape might > > actually bring better performance) but I assume the style (oxygen) can deal > > this more efficiently (via polishment) and also globally (not only for the > > folderview plasmoid but _all_ Qt icon drags) > > Gonna try and send Hugo a "patch" if it works. > > Thomas Lübking wrote: > Yes, is. As trivial as > if (widget->testAttribute(Qt::WA_X11NetWmWindowTypeDND) && > FX::compositingActive()) // uses KWindowSystem, FX is bespin > { > widget->setAttribute(Qt::WA_TranslucentBackground); > widget->clearMask(); > } > > Mathias Stephan Panzenböck wrote: > If you have *a lot* of desktop icons and drag them all, the current code > (using a mask and no ARGB window) makes kwin so slow, that the automatic > desktop effects deactivation kicks in. So I think just for that it is worth > to apply this (or a similar) patch. Also I think using these masked icons are > really ugly. If no ARGB window can be used it would be better to use drag > icons like dolphin does.
I agree with Thomas it would be much less of a hack if it goes in the style. Will add in there. (PS: I see other places where I'd love ARGB in DND, namely when moving title windows around for "window tabbing"). - Hugo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101463/#review3574 ----------------------------------------------------------- On April 19, 2012, 11:29 p.m., Mathias Stephan Panzenböck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101463/ > ----------------------------------------------------------- > > (Updated April 19, 2012, 11:29 p.m.) > > > Review request for KDE Base Apps. > > > Description > ------- > > This patch makes dragged folderview icons translucent if composite is > enabled. It is a kinda hack that uses an event filter to find Qt's D'n'D > window, clears any mask on it and sets the Qt::WA_TranslucentBackground > attribute. I use it day to day and it works fine. > > The proper place to fix this would be in Qt, but they wrongfully marked the > bug report as invalid, because they think X11 does not support translucent > windows: > http://bugreports.qt.nokia.com/browse/QTBUG-8519 > > > This addresses bug 256475. > http://bugs.kde.org/show_bug.cgi?id=256475 > > > Diffs > ----- > > plasma/applets/folderview/iconview.h e648ff0 > plasma/applets/folderview/iconview.cpp 3186b18 > > Diff: http://git.reviewboard.kde.org/r/101463/diff/ > > > Testing > ------- > > > Thanks, > > Mathias Stephan Panzenböck > >