----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104511/#review13422 -----------------------------------------------------------
This review has been submitted with commit 654fa56348058ab8155a1ff87002771d87d63768 by Bernd Buschinski to branch KDE/4.8. - Commit Hook On April 30, 2012, 6:59 p.m., Bernd Buschinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104511/ > ----------------------------------------------------------- > > (Updated April 30, 2012, 6:59 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames > > NOTE: Array was left out on purpose, as currentl imeplementation does not > save attributes (next patch will fix this) > > keys&GetOwnPropertyNames requieres to change the > JSObject::getOwnPropertyNames implementation, > for future use a enum is better than than a bool, maybe there will be more > ways to include/exclude properties. > > All changes for khtml/ecma/ are to silense the -Woverloaded-virtual warnings > > > Diffs > ----- > > khtml/ecma/debugger/localvariabledock.cpp 289c910 > khtml/ecma/kjs_css.h aba44b8 > khtml/ecma/kjs_css.cpp e3e7417 > khtml/ecma/kjs_data.cpp df6fa85 > khtml/ecma/kjs_dom.h d0433c3 > khtml/ecma/kjs_dom.cpp 5fff7e3 > khtml/ecma/kjs_html.h 0f3f544c > khtml/ecma/kjs_html.cpp e3da95c > khtml/ecma/kjs_scriptable.h af5343c > khtml/ecma/kjs_scriptable.cpp 5d4ea68 > kjs/JSVariableObject.h a8f01eb > kjs/JSVariableObject.cpp b00ef76 > kjs/array_instance.h 3f2b630 > kjs/array_instance.cpp fe9b8b4 > kjs/function.h 3757fe8 > kjs/function.cpp 5f39ae6 > kjs/object.h 047c242 > kjs/object.cpp c19122f > kjs/object_object.cpp 986f03f > kjs/property_map.h 6b127ff > kjs/property_map.cpp b2ff08e > kjs/string_object.h e890d52 > kjs/string_object.cpp 170e2f7 > > Diff: http://git.reviewboard.kde.org/r/104511/diff/ > > > Testing > ------- > > ecma script & daily surfing > > > Thanks, > > Bernd Buschinski > >