----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104680/#review13425 -----------------------------------------------------------
This review has been submitted with commit 4d326a3f143e7a270003704a2d2d85d27faaa564 by Bernd Buschinski to branch KDE/4.8. - Commit Hook On April 19, 2012, 7:41 p.m., Bernd Buschinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104680/ > ----------------------------------------------------------- > > (Updated April 19, 2012, 7:41 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > kjs: All prototype constructor should be [[Writable]]: true, [[Enumerable]]: > false, [[Configurable]]: true > > > As said in ECMA Edition 5.1r6 - 15.1: > > "Unless otherwise specified, the standard built-in properties of the global > object have attributes {[[Writable]]: true, [[Enumerable]]: false, > [[Configurable]]: true}." > > And it is not otherwise specified. > > > Diffs > ----- > > kjs/interpreter.cpp cf1acf1 > > Diff: http://git.reviewboard.kde.org/r/104680/diff/ > > > Testing > ------- > > Confirmed by ecmascript tests checking the attributes of > *.prototype.constrictor with Object.getOwnPropertyDescriptor > like > Object.getOwnPropertyDescriptor(Date.prototype, "constructor"); > > > Thanks, > > Bernd Buschinski > >
