----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104860/#review13604 -----------------------------------------------------------
OK, except for const QChar &. kio/kio/dataprotocol.cpp <http://git.reviewboard.kde.org/r/104860/#comment10794> Not sure a const ref is a good idea, for a QChar (which is basically a ushort). E.g. QString::at() and [] return a QChar, not a const ref. kio/kio/dataprotocol.cpp <http://git.reviewboard.kde.org/r/104860/#comment10795> same here - David Faure On May 6, 2012, 6:10 p.m., Rolf Eike Beer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104860/ > ----------------------------------------------------------- > > (Updated May 6, 2012, 6:10 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > -add some "const" and "static" > -remove function parameters that always have the same values, use local > statics > in the function to hold these > -QChar(QLatin1Char('\0')) => QChar() > -QChar == QLatin1Char('\0') => QChar::isNull() > > > Diffs > ----- > > kio/kio/dataprotocol.cpp e614476 > > Diff: http://git.reviewboard.kde.org/r/104860/diff/ > > > Testing > ------- > > -build whole kdelibs > -dataprotocol testcases still pass > > > Thanks, > > Rolf Eike Beer > >