> On May 9, 2012, 6:30 p.m., Mark Gaiser wrote: > > Ehh optional perhaps? > > I've seen forms behave like this before and back then when i first saw it i > > tried to delete the text.. Which obviously didn't happen. The text just > > disappears as soon as i start typing. I kinda dislike that behavior. I > > mean, there is a big fat blue focus border that has the purpose of telling > > the user that the one with the blue border (style dependent) is the one > > that currently has focus. The blinking cursor is yet another indication > > that the field has focus. I think that is enough. > > > > Perhaps optional, but please not by default. This is just my opinion and i > > don't maintain plasma components (nor anything in KDE for that matter). > > You'd have to wait for a reply from some of the plasma component > > maintainers to get a final word on this.
This just fixes a race condition, I don't quite understand your reservation, Mark? - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104895/#review13617 ----------------------------------------------------------- On May 9, 2012, 4:53 p.m., Sebastian Gottfried wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104895/ > ----------------------------------------------------------- > > (Updated May 9, 2012, 4:53 p.m.) > > > Review request for KDE Runtime. > > > Description > ------- > > Rationale: This allows the application to pre-focus a text field with a > placeholder text for the user. In the version before this would have > hidden the placeholder text and it may not have been obvious for user > what he was expected to enter in the text field. > > > Diffs > ----- > > plasma/declarativeimports/plasmacomponents/qml/TextArea.qml 2d9e89f > plasma/declarativeimports/plasmacomponents/qml/TextField.qml 4ed15d9 > > Diff: http://git.reviewboard.kde.org/r/104895/diff/ > > > Testing > ------- > > Used it in ktouch/next, works fine. > > > Screenshots > ----------- > > Form in KTouch > http://git.reviewboard.kde.org/r/104895/s/562/ > > > Thanks, > > Sebastian Gottfried > >
