----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104934/#review13940 -----------------------------------------------------------
This review has been submitted with commit 9cfafa78940e7db68f05957ca701e58f770cbda2 by Aurélien Gâteau to branch KDE/4.8. - Commit Hook On May 14, 2012, 8:36 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104934/ > ----------------------------------------------------------- > > (Updated May 14, 2012, 8:36 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > Attached patch tries to define tooltips for most of kdeui standard actions. > The goal of this change is to try to bring value to the tooltips of toolbar > buttons, instead of simply repeating the button text (I wrote a blog post > about this: > http://agateau.com/2012/05/11/common-user-interface-mistakes-in-kde-applications-part-5-big-toolbars/ > ). > > I tried to come up with tooltips which would remain generic enough in a wide > range of contexts, but couldn't find generic-enough tooltips for every > actions. In this case I left the tooltip empty, which cause QToolButton to > use the action text as tooltip, as before. > > If you have suggestions for the missing tooltips or corrections to the > tooltips I came up with (I am not a native english speaker), please comment. > > > Diffs > ----- > > kdeui/actions/kstandardaction.cpp 2312cc1 > kdeui/actions/kstandardaction_p.h f6e6ae7 > kdeui/actions/ktogglefullscreenaction.cpp 8d03d6e > > Diff: http://git.reviewboard.kde.org/r/104934/diff/ > > > Testing > ------- > > Tested with a few KDE applications: KWrite, Kate, Dolphin, Gwenview. Checked > improved tooltips are shown and code still falls back to action text if no > tooltip is defined. > > > Thanks, > > Aurélien Gâteau > >
