----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104983/ -----------------------------------------------------------
(Updated May 22, 2012, 7:14 p.m.) Review request for kdelibs. Changes ------- Draw our own drop down arrow so it looks the same regardless the kde style being in use. Description ------- The patch enable rendering of css border for styled select elements (combobox+listview). This is done by using KdeUiProxyStyle as already done by other widgets in khtml. For styled combobox the drop down arrow is rendered by drawing PE_IndicatorArrowDown of the base style, so it will look different depending on the system style being in use. This addresses bugs 299934 and 300227. http://bugs.kde.org/show_bug.cgi?id=299934 http://bugs.kde.org/show_bug.cgi?id=300227 Diffs (updated) ----- khtml/css/html4.css 9f4d17b khtml/rendering/render_form.h 2be4df5 khtml/rendering/render_form.cpp b4cf136 Diff: http://git.reviewboard.kde.org/r/104983/diff/ Testing ------- . khtml testregression -> no further test fails . tested against different basestyle: oxygen, qtcurve, available qt styles (plastique, qcleanlooks ...) . tested against Qt 4.7.4, Qt 4.8.1 . daily browsing Screenshots ----------- shoot of a bko page before/after the patch http://git.reviewboard.kde.org/r/104983/s/573/ Thanks, Andrea Iacovitti