On 6 June 2012 02:19, Dawit A <ada...@kde.org> wrote: > It is a simple matter to put a #ifdef around the code that does not compile > with Qt 4.7. I wish this issue was raised when the code was up for review > for more than a month or the Qt documentation mentioned something about > those functions only being available in Qt 4.8. > > Anyhow, I have attached a patch that should make it compile on Qt 4.7.x. If > someone is willing to test it against Qt 4.7 and let me know if it compiles > and works fine for them, I can commit it. It will however mean that > bug# 275524 will not be fixed for those using Qt 4.7. > > On Tue, Jun 5, 2012 at 3:16 PM, Albert Astals Cid <aa...@kde.org> wrote: >> >> On May 19, Dawit Alemayehu commited a change that uses >> QSslConfiguration::testSslOption that is only available in Qt 4.8 >> >> This means that both kdelibs 4.8.4 and kdelibs 4.9 now depend in Qt 4.8 >> instead Qt 4.7 >> >> I want to ask the kdelibs maintainers: >> >> a) Do you think it makes sense to change our Qt required version from >> Qt 4.7 in kdelibs 4.8.3 >> to >> Qt 4.8 in kdelibs 4.8.4 >> ? >> >> b) Do you think kdelibs 4.9 should depend in Qt 4.8 or not?
Just checked the Qt docs for 4.8 and this new method is not marked as new in 4.8, bad Qt coder! To re-iterate, it is policy that any dependency changes are discussed and approved on k-c-d first. It is probably preferred not to up the required version in a bugfix release unless there is a severe security issue. It is also preferred that any dependency changes are made optional where possible. Perhaps I could suggest that kdelibs devs should only use the minimum version required of Qt rather than the latest and greatest version? John.
