Re: Review Request: kjs: FunctionObject prototype attribute should be [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: false

[Bernd Buschinski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105122/
-----------------------------------------------------------

(Updated June 18, 2012, 10:23 p.m.)


Review request for kdelibs.


Changes
-------

ok the new patch handles
1) function foo() {};
2) var x = function foo() {};
3) var x = new Function();

for the 1. I need the change in nodes.cpp

for the 2. I need the change in bytecode/codes.def

for the 3. I need the change in function_object.cpp


Description
-------

kjs: FunctionObject prototype attribute should be [[Writable]]: true, 
[[Enumerable]]: false, [[Configurable]]: false
ECMA Edition 5.1r6 - 15.3.5.2

the prototype must have DontEnum property otherwise it shows up as enumerable 
key.


I expected that this must be fixed in the function_object.cpp constructor, but 
its never used in for code like

function foo() {};


Diffs (updated)
-----

  kjs/bytecode/codes.def ae0a59f 
  kjs/function_object.cpp 4000212 
  kjs/nodes.cpp 0b0749a 

Diff: http://git.reviewboard.kde.org/r/105122/diff/


Testing
-------


Thanks,

Bernd Buschinski