> On June 21, 2012, 10:05 p.m., Mark Gaiser wrote: > > I don't really know if we should do this.. I do understand why you want to > > rename it. From a user point of view the user probably wants to either > > access windows shares or make shares accessible for windows. Either way, > > it's done through Samba which implements the SMB protocol: > > http://en.wikipedia.org/wiki/Server_Message_Block so it are actually "SMB > > Shares" ;) > > > > Changing it is not really useful i think. I for example make "Samba shares" > > between Linux machines as well since that is just easy and why should those > > be called "Windows Shares" all of a sudden? I think "Samba Shares" is just > > fine. Perhaps "SMB Shares" describes it even better. > > > > I'm not against the change, but also not in favor. Someone else should > > decide whether this is OK or not.
I am also against this change, also because Windows is a trademark, so we have better avoid using it in KDE. OBS: samba also implements the cifs protocol, the sucessor of SMB and the current default protocol used in Win7. So "SMB Shares" is also not a good name. - Lamarque Vieira ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105318/#review14969 ----------------------------------------------------------- On June 21, 2012, 3:40 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105318/ > ----------------------------------------------------------- > > (Updated June 21, 2012, 3:40 p.m.) > > > Review request for KDE Runtime and David Edmundson. > > > Description > ------- > > Fix for bug 141257. Renamed 'Samba Shares' to 'Windows Shares (SMB)' > > I posted this on the usability mailing list a while a go and David Edmundson > CC'd the original author but for now there has been no response. > http://lists.kde.org/?l=kde-usability&m=133173657001169&w=2 > > Since we are past string freeze this is probably for 4.10 > I can not commit this myself, thanks > > > This addresses bug 141257. > http://bugs.kde.org/show_bug.cgi?id=141257 > > > Diffs > ----- > > kioslave/smb/smb-network.desktop a121a31 > > Diff: http://git.reviewboard.kde.org/r/105318/diff/ > > > Testing > ------- > > > Thanks, > > Maarten De Meyer > >