----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105278/#review15037 -----------------------------------------------------------
This review has been submitted with commit e643ed3935ef538d9685edc5dbf10c5f36508364 by Jaime Torres to branch KDE/4.8. - Commit Hook On June 16, 2012, 3:37 p.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105278/ > ----------------------------------------------------------- > > (Updated June 16, 2012, 3:37 p.m.) > > > Review request for kdelibs. > > > Description > ------- > > 1. Do not want to check m_startDate.isValid() twice and m_endDate.isValid() > none. > 2. why do not want to delete d->authAction if it is nulled after that. > 3. Is really the code after the break unwanted code? > 4. if ok is not initialized, sometimes while(ok) could do nothing. > > > Diffs > ----- > > kdecore/date/kcalendarera.cpp 0a21e37 > kdeui/actions/kaction.cpp 309cf82 > kio/kfile/kpropertiesdialog.cpp feb0c9e > sonnet/unicode/parseucd/parseucd.cpp 1c9b90e > > Diff: http://git.reviewboard.kde.org/r/105278/diff/ > > > Testing > ------- > > 6 months or more with it locally. > > > Thanks, > > Jaime Torres Amate > >