> On July 12, 2012, 4:20 p.m., David Faure wrote: > > workspace/kio/kio_activities.cpp, line 215 > > <http://git.reviewboard.kde.org/r/105222/diff/1/?file=67362#file67362line215> > > > > This looks like a very ugly workaround, to me. > > > > Does it[1].uri() return a QUrl, or a QString? > > If a QString, then the problem is passing it to the QUrl constructor. > > QUrl in Qt4 is broken in that respect. (Fixed in Qt5). > > Use KUrl instead, or use QUrl::fromEncoded(it[1].uri().toLatin1()). I'd > > prefer KUrl though, to keep this code readable and make it a one-char fix ;)
The problem is uri() return a QUrl, and the url inside it is already encoded. When it passed to createUDSEntryForUrl it actually encoded twice. I wonder we should fix it in soprano or we should fix it when the original url is saved. - Xuetian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105222/#review15736 ----------------------------------------------------------- On June 18, 2012, 6:09 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105222/ > ----------------------------------------------------------- > > (Updated June 18, 2012, 6:09 a.m.) > > > Review request for KDE Runtime and Ivan Čukić. > > > Description > ------- > > The query result for the Uri is already encoded to PercentEncoding, thus > url.url() will not get the correct url. > > Not sure this should always handled in this case, or soprano itself (uri()) > should be fixed. > > > Diffs > ----- > > workspace/kio/kio_activities.cpp 8ef1f7b > > Diff: http://git.reviewboard.kde.org/r/105222/diff/ > > > Testing > ------- > > Works here for utf8 file name. > > > Thanks, > > Xuetian Weng > >
