> On Aug. 6, 2012, 6:09 p.m., Raphael Kubo da Costa wrote: > > How does this play with https://git.reviewboard.kde.org/r/104439 ?
That review addresses a (different) case where chfn to produces a different output to what the kcm is expecting. Unfortunately I do not run either of those distros to test. This change only addresses a configuration where chfn produces no output except on error (and is designed not to interfere with configurations that do). - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105895/#review16989 ----------------------------------------------------------- On Aug. 6, 2012, 5:03 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105895/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2012, 5:03 p.m.) > > > Review request for KDE Base Apps. > > > Description > ------- > > When changing the user's full name, chfn may not necessarily produce any > output. Since readLine blocks, the kcm may hang. > > This change checks if chfn exited without output, and if so, use that exit > status. > > > This addresses bug 156396. > http://bugs.kde.org/show_bug.cgi?id=156396 > > > Diffs > ----- > > kdepasswd/kcm/chfnprocess.cpp 9f75d4aa75b41acec84e7798c789d4226ca3fab9 > > Diff: http://git.reviewboard.kde.org/r/105895/diff/ > > > Testing > ------- > > On a PAM-enabled system: > * Full name changed successfully when permitted by login.defs > * Error presented and no change processed with prohibited by login.defs > > > Thanks, > > Michael Palimaka > >
