----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105628/#review17676 -----------------------------------------------------------
This review has been submitted with commit 9c38b48fb37747de3708a75d73c1f428ece72100 by Allen Winter to branch master. - Commit Hook On Aug. 4, 2012, 12:35 p.m., Allen Winter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105628/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2012, 12:35 p.m.) > > > Review request for KDE Runtime, David Faure and Fredrik Höglund. > > > Description > ------- > > This is an attempt to make the KWallet password prompt much harder to ignore > or miss. > > Now the prompt should always be in front of the parent window. and it should > unminimize if needed, and demand attention. > > [UPDATE] I'm reopening as I still think this is needed, even in 4.9. > I changed the things that gave people heartburn in my first attempt, notably > removing the usertime=0 > > > Diffs > ----- > > kwalletd/kwalletd.cpp 309c45f > > Diff: http://git.reviewboard.kde.org/r/105628/diff/ > > > Testing > ------- > > Just using it in various scenarios. > For example, if the akonadi maildispatcher needs to open kwallet now the > password prompt is always in front of kmail > > [UPDATE] Without the usertime=0, you can still move kmail in front of the > password prompt dialog. but at least you see the prompt first. > > > Thanks, > > Allen Winter > >
