----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106212/#review18029 -----------------------------------------------------------
That warning is there to remind the maintainer to re-factor that code and get rid of that message ;-) I’d vote for using a KNotify notification: 1. the user can configure it in a way he wants to (ie. show message? play sound? run application when event occurs?) and 2. it is a passive notification that emerges from the notification area rather than a dialog popping out of nowhere with no context. FTR: I already made a patch half a year ago or so but was told there was going to be a major refactor in this area and so I left it. - Kai Uwe Broulik On Aug. 26, 2012, 8:40 a.m., Frederik Gladhorn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106212/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2012, 8:40 a.m.) > > > Review request for KDE Base Apps and Alex Fiestas. > > > Description > ------- > > The dialog from the kded would show up once for each event (eg unpluggin and > pluggin in again) related to monitor changes. > I wonder what the "#warning Modal dialog, stupid, fix." was supposed to fix. > The dialog was redone since it's actually not very easy to re-use KMessageBox > in a non-modal way. > > > Diffs > ----- > > kcontrol/randr/module/randrmonitor.h 057c991 > kcontrol/randr/module/randrmonitor.cpp 32d0d0a > > Diff: http://git.reviewboard.kde.org/r/106212/diff/ > > > Testing > ------- > > > Thanks, > > Frederik Gladhorn > >
